Skip to content

Make RESTRequest work with both WooCommerce and WordPress API. #8590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

Make RESTRequest work with both WooCommerce and WordPress API. #8590

merged 1 commit into from
Jan 9, 2023
+59 −11

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Jan 9, 2023 •
edited
Loading

Part of: #8566

Description

Previously, RESTRequest only had the option to receive WooAPIVersion as API version.

In future, we need to send RESTRequests from MediaRemote using WordPress API to perform media-related actions.

To prepare RESTRequest to handle WordPress API, this PR adds WordPressAPIVersion handling ability to RESTRequest

Testing instructions

  • CI passing should be enough. (WordPressAPIVersion on RESTRequest will be used in a future PR which will MediaRemote endpoints.)

Screenshots

NA

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@selanthiraiyan selanthiraiyan added type: task An internally driven task. feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. labels Jan 9, 2023
@selanthiraiyan selanthiraiyan mentioned this pull request Jan 9, 2023
Closed
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 9, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8590-60a9964 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan added this to the 11.9 milestone Jan 9, 2023
@selanthiraiyan selanthiraiyan marked this pull request as ready for review January 9, 2023 10:47
@itsmeichigo itsmeichigo self-assigned this Jan 9, 2023
itsmeichigo
itsmeichigo approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@selanthiraiyan selanthiraiyan merged commit 47a2586 into trunk Jan 9, 2023
@selanthiraiyan selanthiraiyan deleted the feat/8566-rest-request-wordpress-api branch January 9, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@jaclync jaclync Awaiting requested review from jaclync

Assignees

@itsmeichigo itsmeichigo

Labels

feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. type: task An internally driven task.

Projects

None yet

Milestone

11.9

Development

Successfully merging this pull request may close these issues.

4 participants

@selanthiraiyan @wpmobilebot @itsmeichigo